refactor(express): splits decrpt into v1 and v2#8553
Merged
rishikeshdadam136 merged 1 commit intomasterfrom Apr 22, 2026
Merged
refactor(express): splits decrpt into v1 and v2#8553rishikeshdadam136 merged 1 commit intomasterfrom
rishikeshdadam136 merged 1 commit intomasterfrom
Conversation
rishikeshdadam136
force-pushed
the
WCI-184
branch
2 times, most recently
from
ce55bc8 to
623d42a
Compare
rishikeshdadam136
requested a deployment
to
breaking-changes-override
GitHub Actions
Waiting
rishikeshdadam136
force-pushed
the
WCI-184
branch
from
623d42a to
c8232c1
Compare
rishikeshdadam136
requested a deployment
to
breaking-changes-override
GitHub Actions
Waiting
Contributor
Author
yes tested both v1 and v2 in local |
rishikeshdadam136
force-pushed
the
WCI-184
branch
from
c8232c1 to
2dd5d11
Compare
rishikeshdadam136
requested a deployment
to
breaking-changes-override
GitHub Actions
Waiting
pranavjain97
previously approved these changes
Apr 20, 2026
lokesh-bitgo
previously approved these changes
Apr 21, 2026
vmccarty
requested changes
Apr 21, 2026
Contributor
vmccarty
left a comment
vmccarty
left a comment
There was a problem hiding this comment.
The "breaking" change is okay, but the endpoints need to be marked as either private or public. Not sure why CI didn't flag it here.
rishikeshdadam136
dismissed stale reviews from lokesh-bitgo and pranavjain97
via
b804d8b
rishikeshdadam136
force-pushed
the
WCI-184
branch
2 times, most recently
from
b804d8b to
0b2d0c4
Compare
rishikeshdadam136
temporarily deployed
to
breaking-changes-override
GitHub Actions
Inactive
rishikeshdadam136
force-pushed
the
WCI-184
branch
from
0b2d0c4 to
a8dc4ff
Compare
rishikeshdadam136
requested a deployment
to
breaking-changes-override
GitHub Actions
Waiting
rishikeshdadam136
force-pushed
the
WCI-184
branch
from
a8dc4ff to
cc39ba6
Compare
Contributor
Author
|
Resolved the merge conflicts and force pushed again |
rishikeshdadam136
requested a deployment
to
breaking-changes-override
GitHub Actions
Waiting
rishikeshdadam136
force-pushed
the
WCI-184
branch
from
cc39ba6 to
43f025d
Compare
rishikeshdadam136
temporarily deployed
to
breaking-changes-override
GitHub Actions
Inactive
pranavjain97
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WCI-184
Context - https://bitgo.slack.com/archives/C057BHBRG4B/p1764020095794829?thread_ts=1764018507.602879&cid=C057BHBRG4B
The API behavior is not changing. We are splitting the combined v[12] route into two separate V1 and V2 routes, so both will continue to work and clients will not be affected.